Repository navigation
Conversation
|
|
zhumin8
force-pushed
the
chore-fmt-plugin-2.29-reflow-long-strings
branch
from
November 18, 2026 15:18
12e526e to
9a129d2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
Converges the PR
lintformatter (fmt-maven-plugin) with thelibrarian generateformatter (google-java-formatCLI) so long string literals are reflowed consistently before PRs are merged tomain(see #14862, #14896).Changes
com.spotify.fmt:fmt-maven-pluginfrom2.25to2.29injava-shared-config/java-shared-config/pom.xml.<skipReflowingLongStrings>false</skipReflowingLongStrings>soStringWrapper.wrapis executed, matching the default behavior of thegoogle-java-formatCLI.google-java-formatexplicitly pinned to${google-java-format.version}(1.25.2), so Librarian does not need any version change.Follow-up Work
Formatting updates for pre-existing non-complying modules are separated out into follow-up PRs so this
java-shared-configupdate can land cleanly without triggering unrelated downstream test suites:sdk-platform-java:gapic-generator-java(10),gax(8),gax-grpc(1),google-cloud-core(3),google-cloud-core-http(1)java-bigquery/google-cloud-bigquery(13)java-bigquery-jdbc(24)java-spanner-jdbc(21)java-storage-nio/google-cloud-nio(2)grpc-gcp-java(1)java-logging-logback(1)protoc-generated modules (15 files, not to be formatted directly):java-datamanager/proto-data-manager-v1(11),java-marketingplatformadminapi/proto-admin-v1alpha(2),java-grafeas(2)google-java-format1.25.2is not idempotent onprotoc'sdescriptorDatastrings (librarian generate --allruns a single pass matching what is onmain, while a second pass modifies them again)..kokoro/build.shcurrently excludesproto-google-*rather thanproto-*, so those exclusions may need a follow-up beforejava-shared-configis bumped downstream.